[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint/Kconfig: Clean up redefined config options

Arthur Heymans (Code Review) gerrit at coreboot.org
Fri Aug 10 20:41:53 CEST 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/28007


Change subject: sb/intel/lynxpoint/Kconfig: Clean up redefined config options
......................................................................

sb/intel/lynxpoint/Kconfig: Clean up redefined config options

HAVE_IFD_BIN and the likes are redefined in southbridge/intel/common/Kconfig
which presents options under the 'Intel Firmware' section which gets sourced
later than the 'southbridge' section therefore overriding this anyway.

Also all board using this target override HAVE_IFD_BIN to default n, so it is
simpler to just use the defaults in southbridge/intel/common/firmware.

Change-Id: I9999440031b07006e2df11e00dfb9f3dbe04f832
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
4 files changed, 0 insertions(+), 42 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28007/1

diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig
index 428db73..aaec9f7 100644
--- a/src/mainboard/google/beltino/Kconfig
+++ b/src/mainboard/google/beltino/Kconfig
@@ -65,12 +65,4 @@
 	string
 	default "pci8086,0406.rom"
 
-config HAVE_IFD_BIN
-	bool
-	default n
-
-config HAVE_ME_BIN
-	bool
-	default n
-
 endif # BOARD_GOOGLE_BASEBOARD_BELTINO
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index c43b713..6891c0b 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -73,12 +73,4 @@
 	string
 	default "pci8086,0406.rom"
 
-config HAVE_IFD_BIN
-	bool
-	default n
-
-config HAVE_ME_BIN
-	bool
-	default n
-
 endif # BOARD_GOOGLE_BASEBOARD_SLIPPY
diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig
index 445dbcb..1fd07c2 100644
--- a/src/mainboard/intel/baskingridge/Kconfig
+++ b/src/mainboard/intel/baskingridge/Kconfig
@@ -37,12 +37,4 @@
 	string
 	default "pci8086,0166.rom"
 
-config HAVE_IFD_BIN
-	bool
-	default n
-
-config HAVE_ME_BIN
-	bool
-	default n
-
 endif # BOARD_INTEL_BASKING_RIDGE
diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig
index 8d5cbbf..4e5527a 100644
--- a/src/southbridge/intel/lynxpoint/Kconfig
+++ b/src/southbridge/intel/lynxpoint/Kconfig
@@ -57,28 +57,10 @@
 	  If you set this option to y, the serial IRQ machine will be
 	  operated in continuous mode.
 
-config HAVE_IFD_BIN
-	bool
-	default y
-
 config BUILD_WITH_FAKE_IFD
 	bool
 	default y if !HAVE_IFD_BIN
 
-config IFD_BIN_PATH
-	string
-	depends on !BUILD_WITH_FAKE_IFD
-	default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin"
-
-config HAVE_ME_BIN
-	bool
-	default y
-
-config ME_BIN_PATH
-	string
-	depends on HAVE_ME_BIN
-	default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin"
-
 config ME_MBP_CLEAR_LATE
 	bool "Defer wait for ME MBP Cleared"
 	default y

-- 
To view, visit https://review.coreboot.org/28007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9999440031b07006e2df11e00dfb9f3dbe04f832
Gerrit-Change-Number: 28007
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180810/4c25b86c/attachment-0001.html>


More information about the coreboot-gerrit mailing list