<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28007">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/intel/lynxpoint/Kconfig: Clean up redefined config options<br><br>HAVE_IFD_BIN and the likes are redefined in southbridge/intel/common/Kconfig<br>which presents options under the 'Intel Firmware' section which gets sourced<br>later than the 'southbridge' section therefore overriding this anyway.<br><br>Also all board using this target override HAVE_IFD_BIN to default n, so it is<br>simpler to just use the defaults in southbridge/intel/common/firmware.<br><br>Change-Id: I9999440031b07006e2df11e00dfb9f3dbe04f832<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/google/beltino/Kconfig<br>M src/mainboard/google/slippy/Kconfig<br>M src/mainboard/intel/baskingridge/Kconfig<br>M src/southbridge/intel/lynxpoint/Kconfig<br>4 files changed, 0 insertions(+), 42 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28007/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig</span><br><span>index 428db73..aaec9f7 100644</span><br><span>--- a/src/mainboard/google/beltino/Kconfig</span><br><span>+++ b/src/mainboard/google/beltino/Kconfig</span><br><span>@@ -65,12 +65,4 @@</span><br><span>       string</span><br><span>       default "pci8086,0406.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif # BOARD_GOOGLE_BASEBOARD_BELTINO</span><br><span>diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig</span><br><span>index c43b713..6891c0b 100644</span><br><span>--- a/src/mainboard/google/slippy/Kconfig</span><br><span>+++ b/src/mainboard/google/slippy/Kconfig</span><br><span>@@ -73,12 +73,4 @@</span><br><span>    string</span><br><span>       default "pci8086,0406.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif # BOARD_GOOGLE_BASEBOARD_SLIPPY</span><br><span>diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig</span><br><span>index 445dbcb..1fd07c2 100644</span><br><span>--- a/src/mainboard/intel/baskingridge/Kconfig</span><br><span>+++ b/src/mainboard/intel/baskingridge/Kconfig</span><br><span>@@ -37,12 +37,4 @@</span><br><span>         string</span><br><span>       default "pci8086,0166.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif # BOARD_INTEL_BASKING_RIDGE</span><br><span>diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig</span><br><span>index 8d5cbbf..4e5527a 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/Kconfig</span><br><span>+++ b/src/southbridge/intel/lynxpoint/Kconfig</span><br><span>@@ -57,28 +57,10 @@</span><br><span>          If you set this option to y, the serial IRQ machine will be</span><br><span>          operated in continuous mode.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-   bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default y</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> config BUILD_WITH_FAKE_IFD</span><br><span>      bool</span><br><span>         default y if !HAVE_IFD_BIN</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config IFD_BIN_PATH</span><br><span style="color: hsl(0, 100%, 40%);">-       string</span><br><span style="color: hsl(0, 100%, 40%);">-  depends on !BUILD_WITH_FAKE_IFD</span><br><span style="color: hsl(0, 100%, 40%);">- default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-   bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default y</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config ME_BIN_PATH</span><br><span style="color: hsl(0, 100%, 40%);">-     string</span><br><span style="color: hsl(0, 100%, 40%);">-  depends on HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-  default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> config ME_MBP_CLEAR_LATE</span><br><span>      bool "Defer wait for ME MBP Cleared"</span><br><span>       default y</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28007">change 28007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9999440031b07006e2df11e00dfb9f3dbe04f832 </div>
<div style="display:none"> Gerrit-Change-Number: 28007 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>