[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: remove icc_max overrides

[Nick Vaccaro (Code Review)]

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/27996


Change subject: mb/google/poppy/variants/nocturne: remove icc_max overrides
......................................................................

mb/google/poppy/variants/nocturne: remove icc_max overrides

Remove icc_max overrides to allow SoC code to set proper
icc_max based on CPU SKU.

BUG=b:78122599
BRANCH=none
TEST='emerge-nocturne coreboot chromeos-bootimage', flash to
nocturne, boot to kernel and verify device doesn't hang after
a few minutes.

Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27996/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 9d9c5ae..2c074e9 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -87,7 +87,7 @@
 	#| Psi4Enable     | 1     | 1     | 1     | 1     |
 	#| ImonSlope      | 0     | 0     | 0     | 0     |
 	#| ImonOffset     | 0     | 0     | 0     | 0     |
-	#| IccMax         | 4A    | 28A   | 24A   | 24A   |
+	#| IccMax         | Set by SoC code per CPU SKU   |
 	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
 	#| AcLoadline     | 14.9  | 4     | 5.7   | 4.57  |
 	#| DcLoadline     | 14.2  | 4     | 4.2   | 4.3   |
@@ -101,7 +101,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(4),
 		.voltage_limit = 1520,
 		.ac_loadline = 1490,
 		.dc_loadline = 1420,
@@ -116,7 +115,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(28),
 		.voltage_limit = 1520,
 		.ac_loadline = 400,
 		.dc_loadline = 400,
@@ -131,7 +129,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
 		.ac_loadline = 570,
 		.dc_loadline = 420,
@@ -146,7 +143,6 @@
 		.psi4enable = 1,
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
 		.ac_loadline = 457,
 		.dc_loadline = 430,

-- 
To view, visit https://review.coreboot.org/27996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582
Gerrit-Change-Number: 27996
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/7ac7722e/attachment.html>