<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27996">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: remove icc_max overrides<br><br>Remove icc_max overrides to allow SoC code to set proper<br>icc_max based on CPU SKU.<br><br>BUG=b:78122599<br>BRANCH=none<br>TEST='emerge-nocturne coreboot chromeos-bootimage', flash to<br>nocturne, boot to kernel and verify device doesn't hang after<br>a few minutes.<br><br>Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 1 insertion(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27996/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 9d9c5ae..2c074e9 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -87,7 +87,7 @@</span><br><span>         #| Psi4Enable     | 1     | 1     | 1     | 1     |</span><br><span>  #| ImonSlope      | 0     | 0     | 0     | 0     |</span><br><span>  #| ImonOffset     | 0     | 0     | 0     | 0     |</span><br><span style="color: hsl(0, 100%, 40%);">-     #| IccMax         | 4A    | 28A   | 24A   | 24A   |</span><br><span style="color: hsl(120, 100%, 40%);">+   #| IccMax         | Set by SoC code per CPU SKU   |</span><br><span>  #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span>  #| AcLoadline     | 14.9  | 4     | 5.7   | 4.57  |</span><br><span>  #| DcLoadline     | 14.2  | 4     | 4.2   | 4.3   |</span><br><span>@@ -101,7 +101,6 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(4),</span><br><span>            .voltage_limit = 1520,</span><br><span>               .ac_loadline = 1490,</span><br><span>                 .dc_loadline = 1420,</span><br><span>@@ -116,7 +115,6 @@</span><br><span>           .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(28),</span><br><span>           .voltage_limit = 1520,</span><br><span>               .ac_loadline = 400,</span><br><span>          .dc_loadline = 400,</span><br><span>@@ -131,7 +129,6 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(24),</span><br><span>           .voltage_limit = 1520,</span><br><span>               .ac_loadline = 570,</span><br><span>          .dc_loadline = 420,</span><br><span>@@ -146,7 +143,6 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(24),</span><br><span>           .voltage_limit = 1520,</span><br><span>               .ac_loadline = 457,</span><br><span>          .dc_loadline = 430,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27996">change 27996</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27996"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582 </div>
<div style="display:none"> Gerrit-Change-Number: 27996 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>