[coreboot-gerrit] Change in coreboot[master]: security/vboot/Makefile: Use shell cat instead of make file command

Raul Rangel (Code Review) gerrit at coreboot.org
Thu Aug 9 20:30:52 CEST 2018


Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27990


Change subject: security/vboot/Makefile: Use shell cat instead of make file command
......................................................................

security/vboot/Makefile: Use shell cat instead of make file command

The make `file` command is apparently a v4.2 feature only. Replace it
with a shell cat.

BUG=none
TEST=verified fwid.region was created correctly

Change-Id: I5e32a521ad3e6759853f0cde2e4c4db6e564d3be
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M src/security/vboot/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/27990/1

diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc
index 7d40428..2b4e7d4 100644
--- a/src/security/vboot/Makefile.inc
+++ b/src/security/vboot/Makefile.inc
@@ -229,7 +229,7 @@
 $(obj)/fwid.region: $(obj)/fwid.version
 	printf "%s%s\0" \
 		"$(CONFIG_VBOOT_FWID_MODEL)" \
-		"$(file < $(obj)/fwid.version)" > $@
+		"$$(cat "$(obj)/fwid.version")" > $@
 
 build_complete:: $(obj)/gbb.region $(obj)/fwid.region
 	@printf "    WRITE GBB\n"

-- 
To view, visit https://review.coreboot.org/27990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e32a521ad3e6759853f0cde2e4c4db6e564d3be
Gerrit-Change-Number: 27990
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/9e1bd4ee/attachment.html>


More information about the coreboot-gerrit mailing list