[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Force USB-C into host mode

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Aug 9 19:46:23 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27746 )

Change subject: soc/intel/apollolake: Force USB-C into host mode
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/27746/7/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/27746/7/src/soc/intel/apollolake/chip.c@680
PS7, Line 680: 	if (reg && SW_IDPIN_EN_MASK) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/27746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca3d25a1159f922b743963cbc508d8defa7b6ff
Gerrit-Change-Number: 27746
Gerrit-PatchSet: 7
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Hannah Williams <hannah.williams at intel.com>
Gerrit-Comment-Date: Thu, 09 Aug 2018 17:46:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/547c0fb8/attachment.html>


More information about the coreboot-gerrit mailing list