[coreboot-gerrit] Change in coreboot[master]: riscv: update misaligned memory access exception handling

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27972 )

Change subject: riscv: update misaligned memory access exception handling
......................................................................


Patch Set 3:

(5 comments)

https://review.coreboot.org/#/c/27972/3/src/arch/riscv/misaligend.c
File src/arch/riscv/misaligend.c:

https://review.coreboot.org/#/c/27972/3/src/arch/riscv/misaligend.c@176
PS3, Line 176: 		int regnum = ((insn >> match->reg_shift) & match->reg_mask) + match->reg_addition;
line over 80 characters


https://review.coreboot.org/#/c/27972/3/src/arch/riscv/misaligend.c@184
PS3, Line 184: 				buff.b[i] = mprv_read_u8((uint8_t *)(tf->badvaddr + i));
line over 80 characters


https://review.coreboot.org/#/c/27972/3/src/arch/riscv/misaligend.c@237
PS3, Line 237: 			/* writing to memory by bytes prevents misaligned memory access */
line over 80 characters


https://review.coreboot.org/#/c/27972/3/src/arch/riscv/misaligend.c@239
PS3, Line 239: 				mprv_write_u8((uint8_t *)(tf->badvaddr + i), buff.b[i]);
line over 80 characters


https://review.coreboot.org/#/c/27972/3/src/arch/riscv/trap_handler.c
File src/arch/riscv/trap_handler.c:

https://review.coreboot.org/#/c/27972/3/src/arch/riscv/trap_handler.c@191
PS3, Line 191: 	write_csr(sepc, read_csr(mepc));
'sepc' may be misspelled - perhaps 'spec'?



-- 
To view, visit https://review.coreboot.org/27972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9983d56245eab1d458a84cb1432aeb805df7a49f
Gerrit-Change-Number: 27972
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 09 Aug 2018 08:24:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/baa1ba51/attachment.html>