[coreboot-gerrit] Change in coreboot[master]: google/kukui: Initialize cbmem to be mepty in romstage
Tristan Hsieh (Code Review)
gerrit at coreboot.org
Thu Aug 9 10:21:07 CEST 2018
Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27973
Change subject: google/kukui: Initialize cbmem to be mepty in romstage
......................................................................
google/kukui: Initialize cbmem to be mepty in romstage
After memory init, cbmem_initialize_empty() should be called in
romstage.
BUG=b:80501386
TEST=Boots correctly on Kukui
Change-Id: I3953104adb7b42079f37a7a0ae38bf64ae1a6074
Signed-off-by: Tristan Shieh <tristan.shieh at mediatek.com>
---
M src/mainboard/google/kukui/romstage.c
M src/soc/mediatek/mt8183/Makefile.inc
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/27973/1
diff --git a/src/mainboard/google/kukui/romstage.c b/src/mainboard/google/kukui/romstage.c
index 342a0ba..da2ac2d 100644
--- a/src/mainboard/google/kukui/romstage.c
+++ b/src/mainboard/google/kukui/romstage.c
@@ -14,6 +14,7 @@
*/
#include <arch/exception.h>
+#include <cbmem.h>
#include <console/console.h>
#include <program_loading.h>
#include <soc/mmu_operations.h>
@@ -29,5 +30,7 @@
mtk_mmu_after_dram();
+ cbmem_initialize_empty();
+
run_ramstage();
}
diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc
index bd0e54f..8fece79 100644
--- a/src/soc/mediatek/mt8183/Makefile.inc
+++ b/src/soc/mediatek/mt8183/Makefile.inc
@@ -20,7 +20,7 @@
verstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c
verstage-y += ../common/wdt.c
-romstage-y += emi.c
+romstage-y += ../common/cbmem.c emi.c
romstage-y += ../common/gpio.c gpio.c
romstage-y += ../common/mmu_operations.c mmu_operations.c
romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c
--
To view, visit https://review.coreboot.org/27973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3953104adb7b42079f37a7a0ae38bf64ae1a6074
Gerrit-Change-Number: 27973
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180809/597c79cb/attachment.html>
More information about the coreboot-gerrit
mailing list