<p>Tristan Hsieh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27973">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/kukui: Initialize cbmem to be mepty in romstage<br><br>After memory init, cbmem_initialize_empty() should be called in<br>romstage.<br><br>BUG=b:80501386<br>TEST=Boots correctly on Kukui<br><br>Change-Id: I3953104adb7b42079f37a7a0ae38bf64ae1a6074<br>Signed-off-by: Tristan Shieh <tristan.shieh@mediatek.com><br>---<br>M src/mainboard/google/kukui/romstage.c<br>M src/soc/mediatek/mt8183/Makefile.inc<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/27973/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kukui/romstage.c b/src/mainboard/google/kukui/romstage.c</span><br><span>index 342a0ba..da2ac2d 100644</span><br><span>--- a/src/mainboard/google/kukui/romstage.c</span><br><span>+++ b/src/mainboard/google/kukui/romstage.c</span><br><span>@@ -14,6 +14,7 @@</span><br><span>  */</span><br><span> </span><br><span> #include <arch/exception.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cbmem.h></span><br><span> #include <console/console.h></span><br><span> #include <program_loading.h></span><br><span> #include <soc/mmu_operations.h></span><br><span>@@ -29,5 +30,7 @@</span><br><span> </span><br><span>      mtk_mmu_after_dram();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     cbmem_initialize_empty();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  run_ramstage();</span><br><span> }</span><br><span>diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>index bd0e54f..8fece79 100644</span><br><span>--- a/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>+++ b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>@@ -20,7 +20,7 @@</span><br><span> verstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c</span><br><span> verstage-y += ../common/wdt.c</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += emi.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += ../common/cbmem.c emi.c</span><br><span> romstage-y += ../common/gpio.c gpio.c</span><br><span> romstage-y += ../common/mmu_operations.c mmu_operations.c</span><br><span> romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27973">change 27973</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27973"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3953104adb7b42079f37a7a0ae38bf64ae1a6074 </div>
<div style="display:none"> Gerrit-Change-Number: 27973 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Hsieh <tristan.shieh@mediatek.com> </div>