[coreboot-gerrit] Change in coreboot[master]: Added multiboot support to cbfstool and made changes to behaviour for...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27957 )

Change subject: Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload
......................................................................


Patch Set 2:

(10 comments)

https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-mkpayload.c
File util/cbfstool/cbfs-mkpayload.c:

https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-mkpayload.c@552
PS2, Line 552: 		" 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr);
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-mkpayload.c@552
PS2, Line 552: 		" 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr);
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c
File util/cbfstool/cbfs-payload-linux.c:

https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@247
PS2, Line 247: 	if ( hdr->boot_sector_magic != 0xAA55 ) {
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@247
PS2, Line 247: 	if ( hdr->boot_sector_magic != 0xAA55 ) {
space prohibited before that close parenthesis ')'


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@251
PS2, Line 251: 	if ( (hdr->header_magic[0] != 'H')||
spaces required around that '||' (ctx:VxE)


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@251
PS2, Line 251: 	if ( (hdr->header_magic[0] != 'H')||
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@252
PS2, Line 252: 		(hdr->header_magic[1] != 'd')||
spaces required around that '||' (ctx:VxE)


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@253
PS2, Line 253: 		(hdr->header_magic[2] != 'r')||
spaces required around that '||' (ctx:VxE)


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfs-payload-linux.c@254
PS2, Line 254: 		(hdr->header_magic[3] != 'S')){
space required before the open brace '{'


https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/27957/2/util/cbfstool/cbfstool.c@768
PS2, Line 768: 		ERROR("Not a supported payload type (ELF / FV / bzImage / Multiboot).\n");
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb808e8750ad81bdf8c4daedb0d91e961eebb70
Gerrit-Change-Number: 27957
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 20:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180808/24ee2505/attachment.html>