[coreboot-gerrit] Change in coreboot[master]: arch/x86/tables.c: Avoid static analysis error for unused value
Richard Spiegel (Code Review)
gerrit at coreboot.org
Wed Aug 8 18:58:49 CEST 2018
Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27958
Change subject: arch/x86/tables.c: Avoid static analysis error for unused value
......................................................................
arch/x86/tables.c: Avoid static analysis error for unused value
Within procedure arch_write_tables, the pointer "rom_table_end" is updated
every time a table is created. However, after creating last table, pointer
rom_table_end is not used, though it is updated. Add a "(void)rom_table_end;"
at the end to avoid the static analysis error.
BUG=b:112253891
TEST=Build and boot grunt.
Change-Id: I8a34026795c7f0d1bb86c5f5c0469d40aa53994a
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/arch/x86/tables.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/27958/1
diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c
index 0a9a3d5..b0c02c2 100644
--- a/src/arch/x86/tables.c
+++ b/src/arch/x86/tables.c
@@ -259,6 +259,7 @@
forwarding_table += sz;
/* Align up to page boundary for historical consistency. */
forwarding_table = ALIGN_UP(forwarding_table, 4*KiB);
+ (void)rom_table_end;
}
void bootmem_arch_add_ranges(void)
--
To view, visit https://review.coreboot.org/27958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a34026795c7f0d1bb86c5f5c0469d40aa53994a
Gerrit-Change-Number: 27958
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180808/29474573/attachment.html>
More information about the coreboot-gerrit
mailing list