[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Fix error treatment

Richard Spiegel (Code Review) gerrit at coreboot.org
Wed Aug 8 00:59:46 CEST 2018


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27951


Change subject: cpu/x86/mp_init.c: Fix error treatment
......................................................................

cpu/x86/mp_init.c: Fix error treatment

In procedure allocate_cpu_devices(), if structure pointer new is null skip
using the the pointer. Add a "continue;" to skip using the pointer.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: I7011fbfa0725f22a6dfbca6752e668eddac3463c
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/cpu/x86/mp_init.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/27951/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index d124721..ff02b16 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -404,6 +404,7 @@
 		if (new == NULL) {
 			printk(BIOS_CRIT, "Could not allocate CPU device\n");
 			max_cpus--;
+			continue;
 		}
 		new->name = processor_name;
 		cpus[i].dev = new;

-- 
To view, visit https://review.coreboot.org/27951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7011fbfa0725f22a6dfbca6752e668eddac3463c
Gerrit-Change-Number: 27951
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/b68c28f0/attachment.html>


More information about the coreboot-gerrit mailing list