[coreboot-gerrit] Change in coreboot[master]: src/device/pci_rom.c: Remove double initialization

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Aug 7 23:52:13 CEST 2018


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27949


Change subject: src/device/pci_rom.c: Remove double initialization
......................................................................

src/device/pci_rom.c: Remove double initialization

In procedure pci_rom_probe(), variable vendev is initialized twice.
Remove one initialization.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: I8a71aa1aea2047ab2d98e09d1d6610de552b6cb4
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/device/pci_rom.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/27949/1

diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 35d3d69..517fb33 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -41,7 +41,7 @@
 	rom_header = cbfs_boot_map_optionrom(dev->vendor, dev->device);
 
 	u32 vendev = (dev->vendor << 16) | dev->device;
-	u32 mapped_vendev = vendev;
+	u32 mapped_vendev;
 
 	mapped_vendev = map_oprom_vendev(vendev);
 

-- 
To view, visit https://review.coreboot.org/27949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a71aa1aea2047ab2d98e09d1d6610de552b6cb4
Gerrit-Change-Number: 27949
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/f077b0f1/attachment.html>


More information about the coreboot-gerrit mailing list