[coreboot-gerrit] Change in coreboot[master]: mb/intel/coffeelake_rvp: Update gpio table for Coffeelake U RVP

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27907 )

Change subject: mb/intel/coffeelake_rvp: Update gpio table for Coffeelake U RVP
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c@20
PS1, Line 20: CONFIG_BOARD_INTEL_COFFEELAKE_RVPU
what about RVP11?


https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c@292
PS1, Line 292: __attribute__((weak))
please don't do this.



-- 
To view, visit https://review.coreboot.org/27907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb55d160ae2d6bff940840b1fba9411979332d4d
Gerrit-Change-Number: 27907
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Tue, 07 Aug 2018 12:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/1b2a87bb/attachment.html>