<p><a href="https://review.coreboot.org/27907">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c">File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">CONFIG_BOARD_INTEL_COFFEELAKE_RVPU</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">what about RVP11?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27907/1/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c@292">Patch Set #1, Line 292:</a> <code style="font-family:monospace,monospace">__attribute__((weak))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please don't do this.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27907">change 27907</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27907"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ieb55d160ae2d6bff940840b1fba9411979332d4d </div>
<div style="display:none"> Gerrit-Change-Number: 27907 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Aug 2018 12:54:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>