[coreboot-gerrit] Change in coreboot[master]: nb/intel/*: Account for cbmem_top alignment

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27871 )

Change subject: nb/intel/*: Account for cbmem_top alignment
......................................................................


Patch Set 4:

> tested on i945g-m4:
 > I'm getting Grub2 boot menu faster.
 > 
 > - Linux start, but can see only one CPU. dmsg: " smpboot:
 > do_boot_cpu failed(-1) to wakeup CPU#1"
 > - S3 not working
 > - "# ./flashrom -p internal", gives :
 > flashrom v0.9.7-r1711 on Linux 4.17.0-1-amd64 (x86_64)
 > flashrom is free software, get the source code at http://www.flashrom.org
 > 
 > Calibrating delay loop... OK.
 > Error accessing high tables, 0x100000 bytes at 0x00000000cef38000
 > /dev/mem mmap failed: Operation not permitted
 > Failed getting access to coreboot high tables.
 > Found chipset "Intel ICH7/ICH7R". Enabling flash write... OK.
 > Found SST flash chip "SST49LF004A/B" (512 kB, FWH) at physical
 > address 0xfff80000.
 > No operations were specified.
 > to solve this, I need to comment line #949 intel/i945/early_init.c
 > 
 > Console log: https://pastebin.com/6QQKQHa7

Do you happen to run with an external GPU?


-- 
To view, visit https://review.coreboot.org/27871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab37b0003f09a680024d5b155ab0bb157920952
Gerrit-Change-Number: 27871
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 06:59:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/c6026d4f/attachment.html>