[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/usb/xhci: Replace raw values with constants

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27883


Change subject: libpayload/drivers/usb/xhci: Replace raw values with constants
......................................................................

libpayload/drivers/usb/xhci: Replace raw values with constants

BUG=none
TEST=compiled on grunt and made sure USB still works in depthcharge

Change-Id: I972f4604bb5ff3838cb15f323c5a579ad890ecf5
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M payloads/libpayload/drivers/usb/xhci.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/27883/1

diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c
index 8972ffa..3f1064a 100644
--- a/payloads/libpayload/drivers/usb/xhci.c
+++ b/payloads/libpayload/drivers/usb/xhci.c
@@ -304,10 +304,10 @@
 	u32 reg_addr;
 	hci_t *controller;
 
-	reg_addr = pci_read_config32 (addr, 0x10) & ~0xf;
-	if (pci_read_config32 (addr, 0x14) > 0) {
+	reg_addr = pci_read_config32(addr, PCI_BASE_ADDRESS_0) &
+		   PCI_BASE_ADDRESS_MEM_MASK;
+	if (pci_read_config32(addr, PCI_BASE_ADDRESS_1) > 0)
 		fatal("We don't do 64bit addressing.\n");
-	}
 
 	controller = xhci_init((unsigned long)reg_addr);
 	if (controller) {

-- 
To view, visit https://review.coreboot.org/27883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972f4604bb5ff3838cb15f323c5a579ad890ecf5
Gerrit-Change-Number: 27883
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/8fdcf1ee/attachment.html>