<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27883">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload/drivers/usb/xhci: Replace raw values with constants<br><br>BUG=none<br>TEST=compiled on grunt and made sure USB still works in depthcharge<br><br>Change-Id: I972f4604bb5ff3838cb15f323c5a579ad890ecf5<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M payloads/libpayload/drivers/usb/xhci.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/27883/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c</span><br><span>index 8972ffa..3f1064a 100644</span><br><span>--- a/payloads/libpayload/drivers/usb/xhci.c</span><br><span>+++ b/payloads/libpayload/drivers/usb/xhci.c</span><br><span>@@ -304,10 +304,10 @@</span><br><span>  u32 reg_addr;</span><br><span>        hci_t *controller;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  reg_addr = pci_read_config32 (addr, 0x10) & ~0xf;</span><br><span style="color: hsl(0, 100%, 40%);">-   if (pci_read_config32 (addr, 0x14) > 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+  reg_addr = pci_read_config32(addr, PCI_BASE_ADDRESS_0) &</span><br><span style="color: hsl(120, 100%, 40%);">+             PCI_BASE_ADDRESS_MEM_MASK;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pci_read_config32(addr, PCI_BASE_ADDRESS_1) > 0)</span><br><span>              fatal("We don't do 64bit addressing.\n");</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span>        controller = xhci_init((unsigned long)reg_addr);</span><br><span>     if (controller) {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27883">change 27883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I972f4604bb5ff3838cb15f323c5a579ad890ecf5 </div>
<div style="display:none"> Gerrit-Change-Number: 27883 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>