[coreboot-gerrit] Change in coreboot[master]: mb/kontron/ktqm77: Use common pnp_{enter, exit} functions

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27868


Change subject: mb/kontron/ktqm77: Use common pnp_{enter,exit} functions
......................................................................

mb/kontron/ktqm77: Use common pnp_{enter,exit} functions

Change-Id: Ib5799cceacefa89385a7615ef1c4b4d06157044f
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/kontron/ktqm77/romstage.c
1 file changed, 3 insertions(+), 16 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27868/1

diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c
index 2a674a5..4afcebb 100644
--- a/src/mainboard/kontron/ktqm77/romstage.c
+++ b/src/mainboard/kontron/ktqm77/romstage.c
@@ -18,7 +18,6 @@
 #include <string.h>
 #include <lib.h>
 #include <timestamp.h>
-#include <arch/io.h>
 #include <device/pci_def.h>
 #include <device/pnp_def.h>
 #include <cpu/x86/lapic.h>
@@ -34,6 +33,7 @@
 #include <arch/cpu.h>
 #include <cpu/x86/msr.h>
 #include <halt.h>
+#include <superio/winbond/common/winbond.h>
 
 void pch_enable_lpc(void)
 {
@@ -62,25 +62,12 @@
 	RCBA32(FD) = reg32;
 }
 
-static void pnp_enter_ext_func_mode(pnp_devfn_t dev)
-{
-	u16 port = dev >> 8;
-	outb(0x87, port);
-	outb(0x87, port);
-}
-
-static void pnp_exit_ext_func_mode(pnp_devfn_t dev)
-{
-	u16 port = dev >> 8;
-	outb(0xaa, port);
-}
-
 void mainboard_config_superio(void)
 {
 	int lvds_3v = 0; /* 0 (5V) or 1 (3V3) */
 	int dis_bl_inv = 1; /* backlight inversion: 1 = disabled, 0 = enabled */
 	pnp_devfn_t dev = PNP_DEV(0x2e, 0x9);
-	pnp_enter_ext_func_mode(dev);
+	pnp_enter_conf_state(dev);
 	pnp_write_config(dev, 0x29, 0x02); /* Pins 119, 120 are GPIO21, 20 */
 	pnp_write_config(dev, 0x30, 0x03); /* Enable GPIO2+3 */
 	pnp_write_config(dev, 0x2a, 0x01); /* Pins 62, 63, 65, 66 are
@@ -94,7 +81,7 @@
 	pnp_write_config(dev, 0xe3, 0xdd); /* GPIO2 bits 1, 5 are output */
 	pnp_write_config(dev, 0xe4, (dis_bl_inv << 5) | (lvds_3v << 1)); /* GPIO2 bits 1, 5 */
 	pnp_write_config(dev, 0xf3, 0x40); /* Disable suspend LED during normal operation */
-	pnp_exit_ext_func_mode(dev);
+	pnp_exit_conf_state(dev);
 }
 
 void mainboard_fill_pei_data(struct pei_data *pei_data)

-- 
To view, visit https://review.coreboot.org/27868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5799cceacefa89385a7615ef1c4b4d06157044f
Gerrit-Change-Number: 27868
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/55f7c48b/attachment.html>