[coreboot-gerrit] Change in coreboot[master]: mb/supermicro/h8qme_fam10: Use common pnp_{enter, exit} functions

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27866


Change subject: mb/supermicro/h8qme_fam10: Use common pnp_{enter,exit} functions
......................................................................

mb/supermicro/h8qme_fam10: Use common pnp_{enter,exit} functions

Change-Id: Ie3ee4acfd272991133f02a56df6e23aa6071d3e9
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/supermicro/h8qme_fam10/romstage.c
1 file changed, 6 insertions(+), 20 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/27866/1

diff --git a/src/mainboard/supermicro/h8qme_fam10/romstage.c b/src/mainboard/supermicro/h8qme_fam10/romstage.c
index f5222ed..ddbb97c 100644
--- a/src/mainboard/supermicro/h8qme_fam10/romstage.c
+++ b/src/mainboard/supermicro/h8qme_fam10/romstage.c
@@ -120,23 +120,9 @@
 #define GPIO2_DEV PNP_DEV(0x2e, W83627HF_GPIO2)
 #define GPIO3_DEV PNP_DEV(0x2e, W83627HF_GPIO3)
 
-/* TODO: superio code should really not be in mainboard */
-static void pnp_enter_ext_func_mode(pnp_devfn_t dev)
-{
-	u16 port = dev >> 8;
-	outb(0x87, port);
-	outb(0x87, port);
-}
-
-static void pnp_exit_ext_func_mode(pnp_devfn_t dev)
-{
-	u16 port = dev >> 8;
-	outb(0xaa, port);
-}
-
 static void write_GPIO(void)
 {
-	pnp_enter_ext_func_mode(GPIO1_DEV);
+	pnp_enter_conf_state(GPIO1_DEV);
 	pnp_set_logical_device(GPIO1_DEV);
 	pnp_write_config(GPIO1_DEV, 0x30, 0x01);
 	pnp_write_config(GPIO1_DEV, 0x60, 0x00);
@@ -147,9 +133,9 @@
 	pnp_write_config(GPIO1_DEV, 0xf0, 0xff);
 	pnp_write_config(GPIO1_DEV, 0xf1, 0xff);
 	pnp_write_config(GPIO1_DEV, 0xf2, 0x00);
-	pnp_exit_ext_func_mode(GPIO1_DEV);
+	pnp_exit_conf_state(GPIO1_DEV);
 
-	pnp_enter_ext_func_mode(GPIO2_DEV);
+	pnp_enter_conf_state(GPIO2_DEV);
 	pnp_set_logical_device(GPIO2_DEV);
 	pnp_write_config(GPIO2_DEV, 0x30, 0x01);
 	pnp_write_config(GPIO2_DEV, 0xf0, 0xef);
@@ -159,16 +145,16 @@
 	pnp_write_config(GPIO2_DEV, 0xf5, 0x48);
 	pnp_write_config(GPIO2_DEV, 0xf6, 0x00);
 	pnp_write_config(GPIO2_DEV, 0xf7, 0xc0);
-	pnp_exit_ext_func_mode(GPIO2_DEV);
+	pnp_exit_conf_state(GPIO2_DEV);
 
-	pnp_enter_ext_func_mode(GPIO3_DEV);
+	pnp_enter_conf_state(GPIO3_DEV);
 	pnp_set_logical_device(GPIO3_DEV);
 	pnp_write_config(GPIO3_DEV, 0x30, 0x00);
 	pnp_write_config(GPIO3_DEV, 0xf0, 0xff);
 	pnp_write_config(GPIO3_DEV, 0xf1, 0xff);
 	pnp_write_config(GPIO3_DEV, 0xf2, 0xff);
 	pnp_write_config(GPIO3_DEV, 0xf3, 0x40);
-	pnp_exit_ext_func_mode(GPIO3_DEV);
+	pnp_exit_conf_state(GPIO3_DEV);
 }
 
 void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)

-- 
To view, visit https://review.coreboot.org/27866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3ee4acfd272991133f02a56df6e23aa6071d3e9
Gerrit-Change-Number: 27866
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/8a583e99/attachment.html>