[coreboot-gerrit] Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 )

Change subject: nb/amd/pi/00730F01: Add initial native IVRS support
......................................................................


Patch Set 23:

(9 comments)

https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c
File src/northbridge/amd/pi/00730F01/northbridge.c:

https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@488
PS23, Line 488: 				    unsigned int depth, int linknum, int8_t *root_level,
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@511
PS23, Line 511: 					add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x97);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@517
PS23, Line 517: 					add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x0);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@521
PS23, Line 521: 				is_pcie = pci_find_capability(dev, PCI_CAP_ID_PCIE);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@526
PS23, Line 526: 					add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x0);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@527
PS23, Line 527: 				} else if ((header_type == PCI_HEADER_TYPE_NORMAL) &&
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@529
PS23, Line 529: 					add_ivhd_dev_entry(parent, dev, current, length, 0x42, 0x0);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@589
PS23, Line 589: 		printk(BIOS_WARNING, "%s: G-series northbridge device not present!\n", __func__);
line over 80 characters


https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/northbridge.c@590
PS23, Line 590: 		printk(BIOS_WARNING, "%s: IVRS table not generated...\n", __func__);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/15164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4
Gerrit-Change-Number: 15164
Gerrit-PatchSet: 23
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 00:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180804/a48402b7/attachment.html>