[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Enable spread spectrum in bootblock

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27813 )

Change subject: soc/amd/stoneyridge: Enable spread spectrum in bootblock
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/27813/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27813/1//COMMIT_MSG@7
PS1, Line 7: soc/amd/sto
> soc/amd/stoneyridge
Done


https://review.coreboot.org/#/c/27813/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/27813/1/src/soc/amd/stoneyridge/southbridge.c@610
PS1, Line 610: enable_aoac_devices()
> Can this go earlier in this list?
I can move it up a bit. Needs to come after ACPI MMIO and CF9 since they are used to setup spread spectrum.



-- 
To view, visit https://review.coreboot.org/27813
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia036ea513ac67d4b8bcf5a78029d969a4ae012a6
Gerrit-Change-Number: 27813
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/3a860ebf/attachment.html>