[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Enable spread spectrum in bootblock

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27813 )

Change subject: soc/amd/stoneyridge: Enable spread spectrum in bootblock
......................................................................


Patch Set 2:

(6 comments)

https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:

https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@380
PS2, Line 380: #define   CG1PLL_SS_STEP_SIZE_DSFRAC_MASK	(0xFFFF << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@382
PS2, Line 382: #define   CG1PLL_SS_AMOUNT_DSFRAC_MASK		(0xFFFF << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/southbridge.h@385
PS2, Line 385: #define   CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK	(0xF << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.c@579
PS2, Line 579: 	cfg5 |= (0x2 << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) & CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK;
line over 80 characters


https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.c@584
PS2, Line 584: 	cfg4 |= (0xD000 << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) & CG1PLL_SS_AMOUNT_DSFRAC_MASK;
line over 80 characters


https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.c@586
PS2, Line 586: 	cfg4 |= (0x02D5 << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) & CG1PLL_SS_STEP_SIZE_DSFRAC_MASK;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27813
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia036ea513ac67d4b8bcf5a78029d969a4ae012a6
Gerrit-Change-Number: 27813
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/411dc5f4/attachment.html>