[coreboot-gerrit] Change in coreboot[master]: mainboard: Add ASUS P8H61-M LX

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27798 )

Change subject: mainboard: Add ASUS P8H61-M LX
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Looks good.

https://review.coreboot.org/#/c/27798/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27798/1//COMMIT_MSG@17
PS1, Line 17: S3 suspend/resume doesn't
            : work
Could be DRAM_RESET_GATE_GPIO incorrectly set? from vendor DSDT I see gpio27 being set high in _PTS but that could be unrelated.


https://review.coreboot.org/#/c/27798/1/Documentation/mainboard/asus/p8h61-m_lx.md
File Documentation/mainboard/asus/p8h61-m_lx.md:

https://review.coreboot.org/#/c/27798/1/Documentation/mainboard/asus/p8h61-m_lx.md@88
PS1, Line 88: --whitelist EFFS,FOVD,MDES,FCRS
you can add these as "config ME_CLEANER_ARGS" in the Kconfig.



-- 
To view, visit https://review.coreboot.org/27798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0579f486d3a44de2dd927fa1e76b90c3b48f62
Gerrit-Change-Number: 27798
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 09:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/918bc8e1/attachment.html>