<p style="white-space: pre-wrap; word-wrap: break-word;">Looks good.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://review.coreboot.org/27798">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27798/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27798/1//COMMIT_MSG@17">Patch Set #1, Line 17:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">S3 suspend/resume doesn't<br>work<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could be DRAM_RESET_GATE_GPIO incorrectly set? from vendor DSDT I see gpio27 being set high in _PTS but that could be unrelated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27798/1/Documentation/mainboard/asus/p8h61-m_lx.md">File Documentation/mainboard/asus/p8h61-m_lx.md:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27798/1/Documentation/mainboard/asus/p8h61-m_lx.md@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace">--whitelist EFFS,FOVD,MDES,FCRS</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">you can add these as "config ME_CLEANER_ARGS" in the Kconfig.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27798">change 27798</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27798"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2a0579f486d3a44de2dd927fa1e76b90c3b48f62 </div>
<div style="display:none"> Gerrit-Change-Number: 27798 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 02 Aug 2018 09:50:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>