[coreboot-gerrit] Change in coreboot[master]: superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks

Tristan Corrick (Code Review) gerrit at coreboot.org
Thu Aug 2 09:57:56 CEST 2018


Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/27796


Change subject: superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks
......................................................................

superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks

When compiling for the ASUS P8H61-M LX, IASL 20180531 emitted the
following remark: "Control Method should be made Serialized (due to
creation of named objects within)". Making the appropriate methods
Serialized eliminates these remarks.

Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/superio/acpi/pnp_generic.asl
M src/superio/acpi/pnp_kbc.asl
M src/superio/acpi/pnp_uart.asl
3 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27796/1

diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl
index c878827..980404e 100644
--- a/src/superio/acpi/pnp_generic.asl
+++ b/src/superio/acpi/pnp_generic.asl
@@ -95,7 +95,7 @@
 	}
 #endif
 
-	Method (_CRS)
+	Method (_CRS, 0, Serialized)
 	{
 		Name (CRS, ResourceTemplate () {
 #ifdef SUPERIO_PNP_IO0
diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl
index db81ea2..cbcfd55 100644
--- a/src/superio/acpi/pnp_kbc.asl
+++ b/src/superio/acpi/pnp_kbc.asl
@@ -73,7 +73,7 @@
 		PNP_DEFAULT_PSC
 	}
 
-	Method (_CRS)
+	Method (_CRS, 0, Serialized)
 	{
 		Name (CRS, ResourceTemplate () {
 			IO (Decode16, 0x0000, 0x0000, 0x01, 0x01, IO0)
@@ -133,7 +133,7 @@
 		Return (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._PSC ())
 	}
 
-	Method (_CRS)
+	Method (_CRS, 0, Serialized)
 	{
 		Name (CRS, ResourceTemplate () {
 			IRQNoFlags (IR1) {}
@@ -188,7 +188,7 @@
 		PNP_DEFAULT_PSC
 	}
 
-	Method (_CRS)
+	Method (_CRS, 0, Serialized)
 	{
 		Name (CRS, ResourceTemplate () {
 			IRQNoFlags (IR1) {}
diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl
index 1bbdb37..f42cc42 100644
--- a/src/superio/acpi/pnp_uart.asl
+++ b/src/superio/acpi/pnp_uart.asl
@@ -79,7 +79,7 @@
 	}
 #endif
 
-	Method (_CRS)
+	Method (_CRS, 0, Serialized)
 	{
 		Name (CRS, ResourceTemplate () {
 			IO (Decode16, 0x0000, 0x0000, 0x08, 0x08, IO0)

-- 
To view, visit https://review.coreboot.org/27796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37
Gerrit-Change-Number: 27796
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/504cf978/attachment.html>


More information about the coreboot-gerrit mailing list