<p>Tristan Corrick has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27796">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks<br><br>When compiling for the ASUS P8H61-M LX, IASL 20180531 emitted the<br>following remark: "Control Method should be made Serialized (due to<br>creation of named objects within)". Making the appropriate methods<br>Serialized eliminates these remarks.<br><br>Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37<br>Signed-off-by: Tristan Corrick <tristan@corrick.kiwi><br>---<br>M src/superio/acpi/pnp_generic.asl<br>M src/superio/acpi/pnp_kbc.asl<br>M src/superio/acpi/pnp_uart.asl<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27796/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl</span><br><span>index c878827..980404e 100644</span><br><span>--- a/src/superio/acpi/pnp_generic.asl</span><br><span>+++ b/src/superio/acpi/pnp_generic.asl</span><br><span>@@ -95,7 +95,7 @@</span><br><span>         }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Method (_CRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span>         {</span><br><span>            Name (CRS, ResourceTemplate () {</span><br><span> #ifdef SUPERIO_PNP_IO0</span><br><span>diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl</span><br><span>index db81ea2..cbcfd55 100644</span><br><span>--- a/src/superio/acpi/pnp_kbc.asl</span><br><span>+++ b/src/superio/acpi/pnp_kbc.asl</span><br><span>@@ -73,7 +73,7 @@</span><br><span>          PNP_DEFAULT_PSC</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   Method (_CRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span>         {</span><br><span>            Name (CRS, ResourceTemplate () {</span><br><span>                     IO (Decode16, 0x0000, 0x0000, 0x01, 0x01, IO0)</span><br><span>@@ -133,7 +133,7 @@</span><br><span>                 Return (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._PSC ())</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   Method (_CRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span>         {</span><br><span>            Name (CRS, ResourceTemplate () {</span><br><span>                     IRQNoFlags (IR1) {}</span><br><span>@@ -188,7 +188,7 @@</span><br><span>            PNP_DEFAULT_PSC</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   Method (_CRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span>         {</span><br><span>            Name (CRS, ResourceTemplate () {</span><br><span>                     IRQNoFlags (IR1) {}</span><br><span>diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl</span><br><span>index 1bbdb37..f42cc42 100644</span><br><span>--- a/src/superio/acpi/pnp_uart.asl</span><br><span>+++ b/src/superio/acpi/pnp_uart.asl</span><br><span>@@ -79,7 +79,7 @@</span><br><span>     }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Method (_CRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_CRS, 0, Serialized)</span><br><span>         {</span><br><span>            Name (CRS, ResourceTemplate () {</span><br><span>                     IO (Decode16, 0x0000, 0x0000, 0x08, 0x08, IO0)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27796">change 27796</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27796"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37 </div>
<div style="display:none"> Gerrit-Change-Number: 27796 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>