[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: Do not override icc_max

[Gaggery Tsai (Code Review)]

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/27791 )

Change subject: mb/google/poppy/variants/atlas: Do not override icc_max
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/atlas/devicetree.cb
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/atlas/devicetree.cb@103
PS2, Line 103: 0
I think 0 is confusing. Suggest to completely removing this line. Also, add one line comment above saying the icc max setting is covered in soc code for different CPU sku.



-- 
To view, visit https://review.coreboot.org/27791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33
Gerrit-Change-Number: 27791
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 05:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/29bcf8db/attachment.html>