<p><a href="https://review.coreboot.org/27791">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/atlas/devicetree.cb">File src/mainboard/google/poppy/variants/atlas/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/atlas/devicetree.cb@103">Patch Set #2, Line 103:</a> <code style="font-family:monospace,monospace">0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think 0 is confusing. Suggest to completely removing this line. Also, add one line comment above saying the icc max setting is covered in soc code for different CPU sku.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27791">change 27791</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27791"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 </div>
<div style="display:none"> Gerrit-Change-Number: 27791 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 02 Aug 2018 05:14:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>