[coreboot-gerrit] Change in coreboot[master]: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines

Gaggery Tsai (Code Review) gerrit at coreboot.org
Thu Aug 2 00:23:53 CEST 2018


Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/27788


Change subject: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines
......................................................................

src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines

This patch applies correct AC/DC loadline settings for Atlas from
VRTT report.

BUG=b/111419622
BRANCH=None
TEST=emerge-atlas coreboot chromeos-bootimage and use DbC to check
     the AC/DC loadline settgins.

Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/27788/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index f6610df..f2c2a12 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -88,8 +88,8 @@
 	#| ImonOffset     | 0     | 0     | 0     | 0     |
 	#| IccMax         | 4A    | 24A   | 24A   | 24A   |
 	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
-	#| AcLoadline     | 14.9  | 5     | 5.7   | 4.57  |
-	#| DcLoadline     | 14.2  | 4.86  | 4.2   | 4.3   |
+	#| AcLoadline     | 14.75 | 4.42  | 4.7   | 4.7   |
+	#| DcLoadline     | 14.2  | 4.2   | 4.41  | 4.41  |
 	#+----------------+-------+-------+-------+-------+
 	register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
 		.vr_config_enable = 1,
@@ -102,7 +102,7 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(4),
 		.voltage_limit = 1520,
-		.ac_loadline = 1490,
+		.ac_loadline = 1475,
 		.dc_loadline = 1420,
 	}"
 
@@ -117,8 +117,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
-		.ac_loadline = 500,
-		.dc_loadline = 486,
+		.ac_loadline = 442,
+		.dc_loadline = 420,
 	}"
 
 	register "domain_vr_config[VR_GT_UNSLICED]" = "{
@@ -132,8 +132,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
-		.ac_loadline = 570,
-		.dc_loadline = 420,
+		.ac_loadline = 470,
+		.dc_loadline = 441,
 	}"
 
 	register "domain_vr_config[VR_GT_SLICED]" = "{
@@ -147,8 +147,8 @@
 		.imon_offset = 0x0,
 		.icc_max = VR_CFG_AMP(24),
 		.voltage_limit = 1520,
-		.ac_loadline = 457,
-		.dc_loadline = 430,
+		.ac_loadline = 470,
+		.dc_loadline = 441,
 	}"
 
 	# PCIe Root port 1 with SRCCLKREQ1#

-- 
To view, visit https://review.coreboot.org/27788
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a
Gerrit-Change-Number: 27788
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180801/f9d8e999/attachment-0001.html>


More information about the coreboot-gerrit mailing list