[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27781 )

Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/27781/3/src/mainboard/lenovo/x1_carbon_gen1/romstage.c
File src/mainboard/lenovo/x1_carbon_gen1/romstage.c:

https://review.coreboot.org/#/c/27781/3/src/mainboard/lenovo/x1_carbon_gen1/romstage.c@116
PS3, Line 116: memcpy(&spd[2], memory, 256);
Not sure if I fully get the comment above but if a configuration has only one slot populated you might want to make this conditional?



-- 
To view, visit https://review.coreboot.org/27781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f
Gerrit-Change-Number: 27781
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 01 Aug 2018 20:26:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180801/77c0b4c5/attachment.html>