<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/27781">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27781/3/src/mainboard/lenovo/x1_carbon_gen1/romstage.c">File src/mainboard/lenovo/x1_carbon_gen1/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27781/3/src/mainboard/lenovo/x1_carbon_gen1/romstage.c@116">Patch Set #3, Line 116:</a> <code style="font-family:monospace,monospace">memcpy(&spd[2], memory, 256);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not sure if I fully get the comment above but if a configuration has only one slot populated you might want to make this conditional?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27781">change 27781</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27781"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f </div>
<div style="display:none"> Gerrit-Change-Number: 27781 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 01 Aug 2018 20:26:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>