[coreboot-gerrit] Change in coreboot[master]: google/banon: Add support for additional RAM types/configs

Matt DeVillier (Code Review) gerrit at coreboot.org
Wed Aug 1 00:23:32 CEST 2018


Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/27764


Change subject: google/banon: Add support for additional RAM types/configs
......................................................................

google/banon: Add support for additional RAM types/configs

Adapted from chromium commits 831a372 and cc96c27
[Banon: board 2nd source DDR memory]

Add support for hynix/H9CCNNN8GTALAR-NUD and Nanya/NT6CL256T32CM-H1

Original-Change-Id: Ifd161ba5ade44e71c88655f760ca66668b5c5178
Original-Change-Id: I5cba13701ed8e037e21d34ed55162ee56291a842
Original-Signed-off-by: T.H. Lin <T.H_Lin at quantatw.com>
Original-Tested-by: TH Lin <t.h_lin at quanta.corp-partner.google.com>
Original-Reviewed-by: Vincent Wang <vwang at chromium.org>
Original-Reviewed-by: YH Lin <yueherngl at chromium.org>
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>

Change-Id: I2166d1025ede33148c7ab623ba59190a342c4736
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/cyan/variants/banon/Makefile.inc
M src/mainboard/google/cyan/variants/banon/spd_util.c
2 files changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/27764/1

diff --git a/src/mainboard/google/cyan/variants/banon/Makefile.inc b/src/mainboard/google/cyan/variants/banon/Makefile.inc
index f6a1f46..7210f15 100644
--- a/src/mainboard/google/cyan/variants/banon/Makefile.inc
+++ b/src/mainboard/google/cyan/variants/banon/Makefile.inc
@@ -26,6 +26,8 @@
 SPD_SOURCES += empty
 SPD_SOURCES += hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD
 SPD_SOURCES += micron_2GiB_dimm_MT52L256M32D1PF
+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD
+SPD_SOURCES += nayna_dimm_NT6CL256T32CM-H1
 
 SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
 
diff --git a/src/mainboard/google/cyan/variants/banon/spd_util.c b/src/mainboard/google/cyan/variants/banon/spd_util.c
index 2c9181e..442a5ba 100644
--- a/src/mainboard/google/cyan/variants/banon/spd_util.c
+++ b/src/mainboard/google/cyan/variants/banon/spd_util.c
@@ -23,11 +23,14 @@
  * 0b0001 - 4GiB total - 2 x 2GiB Samsung K4E8E324EB-EGCF
  * 0b0011 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8JTBLAR
  * 0b0100 - 4GiB total - 2 x 2GiB Micron MT52L256M32D1PF
- *
+ * 0b0101 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8GTALAR
+ * 0b0110 - 4GiB total - 2 x 2GiB NY NT6CL256T32CM-H1
  * 0b1000 - 2GiB total - 1 x 2GiB Samsung K4E8E304EE-EGCE
  * 0b1001 - 2GiB total - 1 x 2GiB Samsung K4E8E324EB-EGCF
  * 0b1011 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8JTBLAR
  * 0b1100 - 2GiB total - 1 x 2GiB Micron MT52L256M32D1PF
+ * 0b1101 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8GTALAR
+ * 0b1110 - 2GiB total - 1 x 2GiB NY NT6CL256T32CM-H1
  */
 
 int get_variant_spd_index(int ram_id, int *dual)
@@ -56,7 +59,13 @@
 	case 4:
 		printk(BIOS_DEBUG, "Micron MT52L256M32D1PF\n");
 		break;
+	case 5:
+		printk(BIOS_DEBUG, "Hynix H9CCNNN8GTALAR\n");
+		break;
 	}
+	case 6:
+		printk(BIOS_DEBUG, "Nanya NT6CL256T32CM-H1\n");
+		break;
 
 	return spd_index;
 }

-- 
To view, visit https://review.coreboot.org/27764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2166d1025ede33148c7ab623ba59190a342c4736
Gerrit-Change-Number: 27764
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180731/7d3ab316/attachment-0001.html>


More information about the coreboot-gerrit mailing list