[coreboot-gerrit] Change in coreboot[master]: atlas: enable trackpad as wake source

[Caveh Jalali (Code Review)]

Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25850

to review the following change.


Change subject: atlas: enable trackpad as wake source
......................................................................

atlas: enable trackpad as wake source

This configures GPP_A23 as a wake source for the trackpad.  we also
need set up GPP_A GPE0_DW0, thus evicting GPP_B.  we don't have any
interesting signals in GPP_B, so we won't be missing it.

i don't have hardware with A23 wired up, so i just tested the wake
source using A19 which is essentially identical to A23.

BUG=b:78541883
TEST=verified we can trackpad can wake system from suspend

Change-Id: If800464c8b2319d758b1823850571919f85bdc6c
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
M src/mainboard/google/poppy/variants/atlas/gpio.c
2 files changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/25850/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index 4444549..8ae9b05 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -11,7 +11,7 @@
 	# Note that GPE events called out in ASL code rely on this
 	# route. i.e. If this route changes then the affected GPE
 	# offset bits also need to be changed.
-	register "gpe0_dw0" = "GPP_B"
+	register "gpe0_dw0" = "GPP_A"
 	register "gpe0_dw1" = "GPP_D"
 	register "gpe0_dw2" = "GPP_E"
 
@@ -252,8 +252,7 @@
 				register "hid" = ""ELAN0000""
 				register "desc" = ""ELAN Touchpad""
 				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)"
-				# TODO(caveh): fix wake source
-				#register "wake" = "GPE0_DWx_19" not possible?
+				register "wake" = "GPE0_DW0_23" # GPP_A23
 				register "probed" = "1" # may not be present
 				device i2c 0x15 on end
 			end
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c
index 58b709e..c1b3ccc 100644
--- a/src/mainboard/google/poppy/variants/atlas/gpio.c
+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c
@@ -59,8 +59,8 @@
 	PAD_CFG_NC(GPP_A21),
 	/* A22 : ISH_GP4 */
 	PAD_CFG_NC(GPP_A22),
-	/* A23 : ISH_GP5 */
-	PAD_CFG_NC(GPP_A23),
+	/* A23 : ISH_GP5 ==> TRACKPAD_INT_L */
+	PAD_CFG_GPI_ACPI_SCI(GPP_A23, NONE, DEEP, INVERT),
 
 	/* B0  : CORE_VID0 ==> NC(TP42) */
 	PAD_CFG_NC(GPP_B0),

-- 
To view, visit https://review.coreboot.org/25850
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If800464c8b2319d758b1823850571919f85bdc6c
Gerrit-Change-Number: 25850
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180426/46eeed09/attachment.html>