<p>Caveh Jalali would like caveh jalali to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/25850">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">atlas: enable trackpad as wake source<br><br>This configures GPP_A23 as a wake source for the trackpad.  we also<br>need set up GPP_A GPE0_DW0, thus evicting GPP_B.  we don't have any<br>interesting signals in GPP_B, so we won't be missing it.<br><br>i don't have hardware with A23 wired up, so i just tested the wake<br>source using A19 which is essentially identical to A23.<br><br>BUG=b:78541883<br>TEST=verified we can trackpad can wake system from suspend<br><br>Change-Id: If800464c8b2319d758b1823850571919f85bdc6c<br>Signed-off-by: Caveh Jalali <caveh@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/atlas/devicetree.cb<br>M src/mainboard/google/poppy/variants/atlas/gpio.c<br>2 files changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/25850/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>index 4444549..8ae9b05 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>@@ -11,7 +11,7 @@</span><br><span>       # Note that GPE events called out in ASL code rely on this</span><br><span>   # route. i.e. If this route changes then the affected GPE</span><br><span>    # offset bits also need to be changed.</span><br><span style="color: hsl(0, 100%, 40%);">-  register "gpe0_dw0" = "GPP_B"</span><br><span style="color: hsl(120, 100%, 40%);">+     register "gpe0_dw0" = "GPP_A"</span><br><span>    register "gpe0_dw1" = "GPP_D"</span><br><span>    register "gpe0_dw2" = "GPP_E"</span><br><span> </span><br><span>@@ -252,8 +252,7 @@</span><br><span>                          register "hid" = ""ELAN0000""</span><br><span>                          register "desc" = ""ELAN Touchpad""</span><br><span>                            register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)"</span><br><span style="color: hsl(0, 100%, 40%);">-                           # TODO(caveh): fix wake source</span><br><span style="color: hsl(0, 100%, 40%);">-                          #register "wake" = "GPE0_DWx_19" not possible?</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "wake" = "GPE0_DW0_23" # GPP_A23</span><br><span>                                register "probed" = "1" # may not be present</span><br><span>                             device i2c 0x15 on end</span><br><span>                       end</span><br><span>diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>index 58b709e..c1b3ccc 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>@@ -59,8 +59,8 @@</span><br><span>         PAD_CFG_NC(GPP_A21),</span><br><span>         /* A22 : ISH_GP4 */</span><br><span>  PAD_CFG_NC(GPP_A22),</span><br><span style="color: hsl(0, 100%, 40%);">-    /* A23 : ISH_GP5 */</span><br><span style="color: hsl(0, 100%, 40%);">-     PAD_CFG_NC(GPP_A23),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* A23 : ISH_GP5 ==> TRACKPAD_INT_L */</span><br><span style="color: hsl(120, 100%, 40%);">+     PAD_CFG_GPI_ACPI_SCI(GPP_A23, NONE, DEEP, INVERT),</span><br><span> </span><br><span>       /* B0  : CORE_VID0 ==> NC(TP42) */</span><br><span>        PAD_CFG_NC(GPP_B0),</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25850">change 25850</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25850"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If800464c8b2319d758b1823850571919f85bdc6c </div>
<div style="display:none"> Gerrit-Change-Number: 25850 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>