[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Fix EC_SMI_GPI

[Daniel Kurtz (Code Review)]

Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25826

to review the following change.


Change subject: mainboard/google/kahlee: Fix EC_SMI_GPI
......................................................................

mainboard/google/kahlee: Fix EC_SMI_GPI

On the kahlee variant, EC_SMI_ODL is connected to GPIO6, which uses
GEVENT 10 (GPE10).  Fix this up, and also clean up the EC_*_GPI
definition format a bit to match the format in the baseboard/gpio.h.

BUG=b:78461678
TEST=build coreboot for kahlee

Change-Id: I9445efbc02559c2a7c90f67bcb0154b04b03a1aa
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h
1 file changed, 3 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/25826/1

diff --git a/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h b/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h
index 26dd175..cf0eaf5 100644
--- a/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h
+++ b/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h
@@ -43,11 +43,8 @@
 
 #endif /* _ACPI__ */
 
-/* AGPIO22 -> GPE3 */
-#define EC_SCI_GPI		3
-
-/* TODO: Fix this */
-/* GPIO_S5_07 is EC_SMI#, but it is bit 23 in GPE_STS and ALT_GPIO_SMI. */
-#define EC_SMI_GPI		23
+/* These define the GPE, not the GPIO. */
+#define EC_SCI_GPI		3	/* AGPIO 22 -> GPE  3 */
+#define EC_SMI_GPI		10	/* AGPIO  6 -> GPE 10 */
 
 #endif /* __VARIANT_GPIO_H__ */

-- 
To view, visit https://review.coreboot.org/25826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9445efbc02559c2a7c90f67bcb0154b04b03a1aa
Gerrit-Change-Number: 25826
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/374702d9/attachment-0001.html>