<p>Daniel Kurtz would like Daniel Kurtz to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/25826">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Fix EC_SMI_GPI<br><br>On the kahlee variant, EC_SMI_ODL is connected to GPIO6, which uses<br>GEVENT 10 (GPE10).  Fix this up, and also clean up the EC_*_GPI<br>definition format a bit to match the format in the baseboard/gpio.h.<br><br>BUG=b:78461678<br>TEST=build coreboot for kahlee<br><br>Change-Id: I9445efbc02559c2a7c90f67bcb0154b04b03a1aa<br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h<br>1 file changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/25826/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h b/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h</span><br><span>index 26dd175..cf0eaf5 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h</span><br><span>+++ b/src/mainboard/google/kahlee/variants/kahlee/include/variant/gpio.h</span><br><span>@@ -43,11 +43,8 @@</span><br><span> </span><br><span> #endif /* _ACPI__ */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* AGPIO22 -> GPE3 */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_SCI_GPI                3</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* TODO: Fix this */</span><br><span style="color: hsl(0, 100%, 40%);">-/* GPIO_S5_07 is EC_SMI#, but it is bit 23 in GPE_STS and ALT_GPIO_SMI. */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_SMI_GPI               23</span><br><span style="color: hsl(120, 100%, 40%);">+/* These define the GPE, not the GPIO. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_SCI_GPI               3       /* AGPIO 22 -> GPE  3 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_SMI_GPI         10      /* AGPIO  6 -> GPE 10 */</span><br><span> </span><br><span> #endif /* __VARIANT_GPIO_H__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25826">change 25826</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25826"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9445efbc02559c2a7c90f67bcb0154b04b03a1aa </div>
<div style="display:none"> Gerrit-Change-Number: 25826 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>