[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Fix smi_write32 arg order in disable_all_smi_status

[Daniel Kurtz (Code Review)]

Daniel Kurtz has uploaded this change for review. ( https://review.coreboot.org/25815


Change subject: soc/amd/stoneyridge: Fix smi_write32 arg order in disable_all_smi_status
......................................................................

soc/amd/stoneyridge: Fix smi_write32 arg order in disable_all_smi_status

The argument order for smi_write32() is offset, value.  Current code had
it backwards.

Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
Fixes:081851a9e4 ("amd/stoneyridge: Add SlpTyp SMI handler")

BUG=b:78461678
TEST=poewrd_dbus_suspend, tapping any key on keyboard wakes from S3.

Change-Id: Ie4fbe6db1bb73f603dcf409117fcce93479a1f46
---
M src/soc/amd/stoneyridge/smihandler.c
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/25815/1

diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c
index 6063789..ef24baa 100644
--- a/src/soc/amd/stoneyridge/smihandler.c
+++ b/src/soc/amd/stoneyridge/smihandler.c
@@ -112,12 +112,12 @@
 
 static void disable_all_smi_status(void)
 {
-	smi_write32(smi_read32(SMI_SCI_STATUS), SMI_SCI_STATUS);
-	smi_write32(smi_read32(SMI_REG_SMISTS0), SMI_REG_SMISTS0);
-	smi_write32(smi_read32(SMI_REG_SMISTS1), SMI_REG_SMISTS1);
-	smi_write32(smi_read32(SMI_REG_SMISTS2), SMI_REG_SMISTS2);
-	smi_write32(smi_read32(SMI_REG_SMISTS3), SMI_REG_SMISTS3);
-	smi_write32(smi_read32(SMI_REG_SMISTS4), SMI_REG_SMISTS4);
+	smi_write32(SMI_SCI_STATUS, smi_read32(SMI_SCI_STATUS));
+	smi_write32(SMI_REG_SMISTS0, smi_read32(SMI_REG_SMISTS0));
+	smi_write32(SMI_REG_SMISTS1, smi_read32(SMI_REG_SMISTS1));
+	smi_write32(SMI_REG_SMISTS2, smi_read32(SMI_REG_SMISTS2));
+	smi_write32(SMI_REG_SMISTS3, smi_read32(SMI_REG_SMISTS3));
+	smi_write32(SMI_REG_SMISTS4, smi_read32(SMI_REG_SMISTS4));
 }
 
 static void sb_slp_typ_handler(void)

-- 
To view, visit https://review.coreboot.org/25815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4fbe6db1bb73f603dcf409117fcce93479a1f46
Gerrit-Change-Number: 25815
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/0bf45212/attachment-0001.html>