<p>Daniel Kurtz has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25815">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge: Fix smi_write32 arg order in disable_all_smi_status<br><br>The argument order for smi_write32() is offset, value.  Current code had<br>it backwards.<br><br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br>Fixes:081851a9e4 ("amd/stoneyridge: Add SlpTyp SMI handler")<br><br>BUG=b:78461678<br>TEST=poewrd_dbus_suspend, tapping any key on keyboard wakes from S3.<br><br>Change-Id: Ie4fbe6db1bb73f603dcf409117fcce93479a1f46<br>---<br>M src/soc/amd/stoneyridge/smihandler.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/25815/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c</span><br><span>index 6063789..ef24baa 100644</span><br><span>--- a/src/soc/amd/stoneyridge/smihandler.c</span><br><span>+++ b/src/soc/amd/stoneyridge/smihandler.c</span><br><span>@@ -112,12 +112,12 @@</span><br><span> </span><br><span> static void disable_all_smi_status(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    smi_write32(smi_read32(SMI_SCI_STATUS), SMI_SCI_STATUS);</span><br><span style="color: hsl(0, 100%, 40%);">-        smi_write32(smi_read32(SMI_REG_SMISTS0), SMI_REG_SMISTS0);</span><br><span style="color: hsl(0, 100%, 40%);">-      smi_write32(smi_read32(SMI_REG_SMISTS1), SMI_REG_SMISTS1);</span><br><span style="color: hsl(0, 100%, 40%);">-      smi_write32(smi_read32(SMI_REG_SMISTS2), SMI_REG_SMISTS2);</span><br><span style="color: hsl(0, 100%, 40%);">-      smi_write32(smi_read32(SMI_REG_SMISTS3), SMI_REG_SMISTS3);</span><br><span style="color: hsl(0, 100%, 40%);">-      smi_write32(smi_read32(SMI_REG_SMISTS4), SMI_REG_SMISTS4);</span><br><span style="color: hsl(120, 100%, 40%);">+    smi_write32(SMI_SCI_STATUS, smi_read32(SMI_SCI_STATUS));</span><br><span style="color: hsl(120, 100%, 40%);">+      smi_write32(SMI_REG_SMISTS0, smi_read32(SMI_REG_SMISTS0));</span><br><span style="color: hsl(120, 100%, 40%);">+    smi_write32(SMI_REG_SMISTS1, smi_read32(SMI_REG_SMISTS1));</span><br><span style="color: hsl(120, 100%, 40%);">+    smi_write32(SMI_REG_SMISTS2, smi_read32(SMI_REG_SMISTS2));</span><br><span style="color: hsl(120, 100%, 40%);">+    smi_write32(SMI_REG_SMISTS3, smi_read32(SMI_REG_SMISTS3));</span><br><span style="color: hsl(120, 100%, 40%);">+    smi_write32(SMI_REG_SMISTS4, smi_read32(SMI_REG_SMISTS4));</span><br><span> }</span><br><span> </span><br><span> static void sb_slp_typ_handler(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25815">change 25815</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25815"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie4fbe6db1bb73f603dcf409117fcce93479a1f46 </div>
<div style="display:none"> Gerrit-Change-Number: 25815 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>