[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Enable EC wake on GPIO24

[Daniel Kurtz (Code Review)]

Daniel Kurtz has uploaded this change for review. ( https://review.coreboot.org/25816


Change subject: mainboard/google/kahlee: Enable EC wake on GPIO24
......................................................................

mainboard/google/kahlee: Enable EC wake on GPIO24

The EC uses GPIO24 (EC_PCH_WAKE_L) to signal wake up events to the AP.
On Stoney, GPIO24 maps to GEVENT (GPE) 15.

Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>

BUG=b:78461678
TEST=poewrd_dbus_suspend, tap any key on keyboard wakes from S3.
TEST=sign in, EC: lidclose, EC: lidopen => system wakes from S3.

Change-Id: Ib1809740837e686992ff70b81933159a5dff7595
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
3 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/25816/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 45f58fd..6605a3c 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -498,6 +498,14 @@
 		.level = SMI_SCI_EDG,
 	},
 
+	/* EC_PCH_WAKE_L_R */
+	{
+		.scimap = 15,
+		.gpe = 15,
+		.direction = SMI_SCI_LVL_LOW,
+		.level = SMI_SCI_EDG,
+	},
+
 	/* H1_PCH_INT_ODL */
 	{
 		.scimap = 22,
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h
index c915ca7..7eef99d 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h
@@ -58,6 +58,7 @@
 
 /* Enable LID switch */
 #define EC_ENABLE_LID_SWITCH
+#define EC_ENABLE_WAKE_PIN EC_WAKE_GPI
 
 /* Enable EC backed ALS device in ACPI */
 #define EC_ENABLE_ALS_DEVICE
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
index 858e33e..be1daa5 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
@@ -42,5 +42,6 @@
 /* These define the GPE, not the GPIO. */
 #define EC_SCI_GPI		3	/* AGPIO 22 -> GPE  3 */
 #define EC_SMI_GPI		10	/* AGPIO 6  -> GPE 10 */
+#define EC_WAKE_GPI		15	/* AGPIO 24 -> GPE 15 */
 
 #endif /* __BASEBOARD_GPIO_H__ */

-- 
To view, visit https://review.coreboot.org/25816
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1809740837e686992ff70b81933159a5dff7595
Gerrit-Change-Number: 25816
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180425/1443aeaa/attachment-0001.html>