<p>Daniel Kurtz has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25816">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Enable EC wake on GPIO24<br><br>The EC uses GPIO24 (EC_PCH_WAKE_L) to signal wake up events to the AP.<br>On Stoney, GPIO24 maps to GEVENT (GPE) 15.<br><br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br><br>BUG=b:78461678<br>TEST=poewrd_dbus_suspend, tap any key on keyboard wakes from S3.<br>TEST=sign in, EC: lidclose, EC: lidopen => system wakes from S3.<br><br>Change-Id: Ib1809740837e686992ff70b81933159a5dff7595<br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h<br>3 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/25816/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index 45f58fd..6605a3c 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -498,6 +498,14 @@</span><br><span>               .level = SMI_SCI_EDG,</span><br><span>        },</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* EC_PCH_WAKE_L_R */</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+             .scimap = 15,</span><br><span style="color: hsl(120, 100%, 40%);">+         .gpe = 15,</span><br><span style="color: hsl(120, 100%, 40%);">+            .direction = SMI_SCI_LVL_LOW,</span><br><span style="color: hsl(120, 100%, 40%);">+         .level = SMI_SCI_EDG,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         /* H1_PCH_INT_ODL */</span><br><span>         {</span><br><span>            .scimap = 22,</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h</span><br><span>index c915ca7..7eef99d 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -58,6 +58,7 @@</span><br><span> </span><br><span> /* Enable LID switch */</span><br><span> #define EC_ENABLE_LID_SWITCH</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_WAKE_PIN EC_WAKE_GPI</span><br><span> </span><br><span> /* Enable EC backed ALS device in ACPI */</span><br><span> #define EC_ENABLE_ALS_DEVICE</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>index 858e33e..be1daa5 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>@@ -42,5 +42,6 @@</span><br><span> /* These define the GPE, not the GPIO. */</span><br><span> #define EC_SCI_GPI              3       /* AGPIO 22 -> GPE  3 */</span><br><span> #define EC_SMI_GPI               10      /* AGPIO 6  -> GPE 10 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_WAKE_GPI                15      /* AGPIO 24 -> GPE 15 */</span><br><span> </span><br><span> #endif /* __BASEBOARD_GPIO_H__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25816">change 25816</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25816"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib1809740837e686992ff70b81933159a5dff7595 </div>
<div style="display:none"> Gerrit-Change-Number: 25816 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>