[coreboot-gerrit] Change in coreboot[master]: cpu/via/car: drop CARTEST

[Lubomir Rintel (Code Review)]

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/25797


Change subject: cpu/via/car: drop CARTEST
......................................................................

cpu/via/car: drop CARTEST

It's broken for years and nobody noticed (%ei for %esi and stackerr for
.Lhlt). It would also leave CAR not zeroed out.

Change-Id: Ib1ca8e8e71ea8d1bf834c349fd6e2ca81538b6eb
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
---
M src/cpu/via/car/cache_as_ram.inc
1 file changed, 0 insertions(+), 32 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/25797/1

diff --git a/src/cpu/via/car/cache_as_ram.inc b/src/cpu/via/car/cache_as_ram.inc
index a131517..4ac82da 100644
--- a/src/cpu/via/car/cache_as_ram.inc
+++ b/src/cpu/via/car/cache_as_ram.inc
@@ -153,18 +153,6 @@
 	xorl	%eax, %eax
 	rep	stosl
 
-#ifdef CARTEST
-	/*
-	 * IMPORTANT: The following calculation _must_ be done at runtime. See
-	 * https://www.coreboot.org/pipermail/coreboot/2010-October/060855.html
-	 */
-	movl	$copy_and_run, %esi
-	andl	$(~(CONFIG_XIP_ROM_SIZE - 1)), %ei
-	movl	%esi, %edi
-	movl	$(CONFIG_XIP_ROM_SIZE >> 2), %ecx
-	rep	lodsl
-#endif
-
 	/*
 	 * The key point of this CAR code is C7 cache does not turn into
 	 * "no fill" mode, which is not compatible with general CAR code.
@@ -173,26 +161,6 @@
 	movl	$(CacheBase + CacheSize - 4), %eax
 	movl	%eax, %esp
 
-#ifdef CARTEST
-testok:
-	post_code(0x40)
-	xorl	%edx, %edx
-	xorl	%eax, %eax
-	movl	$0x5c5c, %edx
-	pushl	%edx
-	pushl	%edx
-	pushl	%edx
-	pushl	%edx
-	pushl	%edx
-	popl	%esi
-	popl	%esi
-	popl	%eax
-	popl	%eax
-	popl	%eax
-	cmpl	%edx, %eax
-	jne	stackerr
-#endif
-
 	/* Restore the BIST result. */
 	movl	%ebp, %eax
 

-- 
To view, visit https://review.coreboot.org/25797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1ca8e8e71ea8d1bf834c349fd6e2ca81538b6eb
Gerrit-Change-Number: 25797
Gerrit-PatchSet: 1
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180423/1359a0d4/attachment-0001.html>