<p>Lubomir Rintel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25797">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cpu/via/car: drop CARTEST<br><br>It's broken for years and nobody noticed (%ei for %esi and stackerr for<br>.Lhlt). It would also leave CAR not zeroed out.<br><br>Change-Id: Ib1ca8e8e71ea8d1bf834c349fd6e2ca81538b6eb<br>Signed-off-by: Lubomir Rintel <lkundrak@v3.sk><br>---<br>M src/cpu/via/car/cache_as_ram.inc<br>1 file changed, 0 insertions(+), 32 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/25797/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/via/car/cache_as_ram.inc b/src/cpu/via/car/cache_as_ram.inc</span><br><span>index a131517..4ac82da 100644</span><br><span>--- a/src/cpu/via/car/cache_as_ram.inc</span><br><span>+++ b/src/cpu/via/car/cache_as_ram.inc</span><br><span>@@ -153,18 +153,6 @@</span><br><span> xorl %eax, %eax</span><br><span> rep stosl</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef CARTEST</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * IMPORTANT: The following calculation _must_ be done at runtime. See</span><br><span style="color: hsl(0, 100%, 40%);">- * https://www.coreboot.org/pipermail/coreboot/2010-October/060855.html</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- movl $copy_and_run, %esi</span><br><span style="color: hsl(0, 100%, 40%);">- andl $(~(CONFIG_XIP_ROM_SIZE - 1)), %ei</span><br><span style="color: hsl(0, 100%, 40%);">- movl %esi, %edi</span><br><span style="color: hsl(0, 100%, 40%);">- movl $(CONFIG_XIP_ROM_SIZE >> 2), %ecx</span><br><span style="color: hsl(0, 100%, 40%);">- rep lodsl</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*</span><br><span> * The key point of this CAR code is C7 cache does not turn into</span><br><span> * "no fill" mode, which is not compatible with general CAR code.</span><br><span>@@ -173,26 +161,6 @@</span><br><span> movl $(CacheBase + CacheSize - 4), %eax</span><br><span> movl %eax, %esp</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef CARTEST</span><br><span style="color: hsl(0, 100%, 40%);">-testok:</span><br><span style="color: hsl(0, 100%, 40%);">- post_code(0x40)</span><br><span style="color: hsl(0, 100%, 40%);">- xorl %edx, %edx</span><br><span style="color: hsl(0, 100%, 40%);">- xorl %eax, %eax</span><br><span style="color: hsl(0, 100%, 40%);">- movl $0x5c5c, %edx</span><br><span style="color: hsl(0, 100%, 40%);">- pushl %edx</span><br><span style="color: hsl(0, 100%, 40%);">- pushl %edx</span><br><span style="color: hsl(0, 100%, 40%);">- pushl %edx</span><br><span style="color: hsl(0, 100%, 40%);">- pushl %edx</span><br><span style="color: hsl(0, 100%, 40%);">- pushl %edx</span><br><span style="color: hsl(0, 100%, 40%);">- popl %esi</span><br><span style="color: hsl(0, 100%, 40%);">- popl %esi</span><br><span style="color: hsl(0, 100%, 40%);">- popl %eax</span><br><span style="color: hsl(0, 100%, 40%);">- popl %eax</span><br><span style="color: hsl(0, 100%, 40%);">- popl %eax</span><br><span style="color: hsl(0, 100%, 40%);">- cmpl %edx, %eax</span><br><span style="color: hsl(0, 100%, 40%);">- jne stackerr</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Restore the BIST result. */</span><br><span> movl %ebp, %eax</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25797">change 25797</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25797"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib1ca8e8e71ea8d1bf834c349fd6e2ca81538b6eb </div>
<div style="display:none"> Gerrit-Change-Number: 25797 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lubomir Rintel <lkundrak@v3.sk> </div>