[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Provide baseboard and variant concepts
Mario Scheithauer (Code Review)
gerrit at coreboot.org
Mon Apr 23 14:02:48 CEST 2018
Hello Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25785
to look at the new patch set (#2).
Change subject: siemens/mc_apl1: Provide baseboard and variant concepts
......................................................................
siemens/mc_apl1: Provide baseboard and variant concepts
Siemens will provide further boards based on Apollo Lake. These differ
only slightly. To avoid copying the complete directory of the reference
board we simply create variants that only contain the differences, like
google/reef does.
To further the ability of multiple variant boards to share code provide
a place to land the split up changes. This patch provides the tooling
using a new Kconfig value, VARIANT_DIR, as well as the Make plumbing.
The directory layout with a single variant mc_apl1 (which is also the
baseboard) looks like this:
variants/baseboard - code
variants/baseboard/include/baseboard - headers
variants/mc_apl1 - code
variants/mc_apl1/include/variant - headers
New boards would then be added under their board name within the
'variants' directory.
No split has been done with providing different logic yet. This is
purely an organizational change.
Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/Kconfig
M src/mainboard/siemens/mc_apl1/Kconfig.name
M src/mainboard/siemens/mc_apl1/Makefile.inc
M src/mainboard/siemens/mc_apl1/board_info.txt
M src/mainboard/siemens/mc_apl1/mainboard.c
M src/mainboard/siemens/mc_apl1/romstage.c
A src/mainboard/siemens/mc_apl1/variants/baseboard/Makefile.inc
R src/mainboard/siemens/mc_apl1/variants/baseboard/devicetree.cb
R src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c
R src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/brd_gpio.h
A src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig
C src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/brd_gpio.h
12 files changed, 55 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25785/2
--
To view, visit https://review.coreboot.org/25785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973
Gerrit-Change-Number: 25785
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180423/ed512e0a/attachment.html>
More information about the coreboot-gerrit
mailing list