<p>Mario Scheithauer <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/25785">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">siemens/mc_apl1: Provide baseboard and variant concepts<br><br>Siemens will provide further boards based on Apollo Lake. These differ<br>only slightly. To avoid copying the complete directory of the reference<br>board we simply create variants that only contain the differences, like<br>google/reef does.<br><br>To further the ability of multiple variant boards to share code provide<br>a place to land the split up changes. This patch provides the tooling<br>using a new Kconfig value, VARIANT_DIR, as well as the Make plumbing.<br>The directory layout with a single variant mc_apl1 (which is also the<br>baseboard) looks like this:<br><br>variants/baseboard - code<br>variants/baseboard/include/baseboard - headers<br>variants/mc_apl1 - code<br>variants/mc_apl1/include/variant - headers<br><br>New boards would then be added under their board name within the<br>'variants' directory.<br><br>No split has been done with providing different logic yet. This is<br>purely an organizational change.<br><br>Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973<br>Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com><br>---<br>M src/mainboard/siemens/mc_apl1/Kconfig<br>M src/mainboard/siemens/mc_apl1/Kconfig.name<br>M src/mainboard/siemens/mc_apl1/Makefile.inc<br>M src/mainboard/siemens/mc_apl1/board_info.txt<br>M src/mainboard/siemens/mc_apl1/mainboard.c<br>M src/mainboard/siemens/mc_apl1/romstage.c<br>A src/mainboard/siemens/mc_apl1/variants/baseboard/Makefile.inc<br>R src/mainboard/siemens/mc_apl1/variants/baseboard/devicetree.cb<br>R src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c<br>R src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/brd_gpio.h<br>A src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig<br>C src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/brd_gpio.h<br>12 files changed, 55 insertions(+), 34 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25785/2</pre><p>To view, visit <a href="https://review.coreboot.org/25785">change 25785</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25785"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973 </div>
<div style="display:none"> Gerrit-Change-Number: 25785 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>