[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Be explicit about *kernel* cmdline arguments

Jonathan Neuschäfer (Code Review) gerrit at coreboot.org
Tue Apr 17 13:11:01 CEST 2018


Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25699


Change subject: util/intelmetool: Be explicit about *kernel* cmdline arguments
......................................................................

util/intelmetool: Be explicit about *kernel* cmdline arguments

Reduce the potential for confusion.

Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M util/intelmetool/me.c
M util/intelmetool/rcba.c
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/25699/1

diff --git a/util/intelmetool/me.c b/util/intelmetool/me.c
index f14f4cd..4867bbc 100644
--- a/util/intelmetool/me.c
+++ b/util/intelmetool/me.c
@@ -583,7 +583,7 @@
 	mei_mmap += mei_base_address - pagerounded;
 	if (mei_mmap == NULL) {
 		printf("Could not map ME setup memory.\n"
-		       "Do you have cmdline argument 'iomem=relaxed' set ?\n");
+		       "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");
 		return 1;
 	}
 
diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c
index ee43e65..6a09af6 100644
--- a/util/intelmetool/rcba.c
+++ b/util/intelmetool/rcba.c
@@ -69,7 +69,7 @@
 	rcba = map_physical((off_t)rcba_phys, size);
 	if (rcba == NULL) {
 		printf("Could not map RCBA\n"
-		       "Do you have cmdline argument 'iomem=relaxed' set ?\n");
+		       "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");
 		return 1;
 	}
 	*(uint32_t *)(rcba + addr) = val;
@@ -95,7 +95,7 @@
 	rcba = map_physical((off_t)rcba_phys, size);
 	if (rcba == NULL) {
 		printf("Could not map RCBA\n"
-		       "Do you have cmdline argument 'iomem=relaxed' set ?\n");
+		       "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");
 		return 1;
 	}
 

-- 
To view, visit https://review.coreboot.org/25699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb
Gerrit-Change-Number: 25699
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180417/4381f9fa/attachment.html>


More information about the coreboot-gerrit mailing list