<p>Jonathan Neuschäfer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25699">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/intelmetool: Be explicit about *kernel* cmdline arguments<br><br>Reduce the potential for confusion.<br><br>Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>---<br>M util/intelmetool/me.c<br>M util/intelmetool/rcba.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/25699/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/intelmetool/me.c b/util/intelmetool/me.c</span><br><span>index f14f4cd..4867bbc 100644</span><br><span>--- a/util/intelmetool/me.c</span><br><span>+++ b/util/intelmetool/me.c</span><br><span>@@ -583,7 +583,7 @@</span><br><span>      mei_mmap += mei_base_address - pagerounded;</span><br><span>  if (mei_mmap == NULL) {</span><br><span>              printf("Could not map ME setup memory.\n"</span><br><span style="color: hsl(0, 100%, 40%);">-                    "Do you have cmdline argument 'iomem=relaxed' set ?\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");</span><br><span>             return 1;</span><br><span>    }</span><br><span> </span><br><span>diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c</span><br><span>index ee43e65..6a09af6 100644</span><br><span>--- a/util/intelmetool/rcba.c</span><br><span>+++ b/util/intelmetool/rcba.c</span><br><span>@@ -69,7 +69,7 @@</span><br><span>   rcba = map_physical((off_t)rcba_phys, size);</span><br><span>         if (rcba == NULL) {</span><br><span>          printf("Could not map RCBA\n"</span><br><span style="color: hsl(0, 100%, 40%);">-                "Do you have cmdline argument 'iomem=relaxed' set ?\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");</span><br><span>             return 1;</span><br><span>    }</span><br><span>    *(uint32_t *)(rcba + addr) = val;</span><br><span>@@ -95,7 +95,7 @@</span><br><span>        rcba = map_physical((off_t)rcba_phys, size);</span><br><span>         if (rcba == NULL) {</span><br><span>          printf("Could not map RCBA\n"</span><br><span style="color: hsl(0, 100%, 40%);">-                "Do you have cmdline argument 'iomem=relaxed' set ?\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                    "Do you have kernel cmdline argument 'iomem=relaxed' set ?\n");</span><br><span>             return 1;</span><br><span>    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25699">change 25699</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25699"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1d5df9acb30948f786f4ced895bbaeed80153fdb </div>
<div style="display:none"> Gerrit-Change-Number: 25699 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>