[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Update EC pins from GPIOs to GPEs
Martin Roth (Code Review)
gerrit at coreboot.org
Mon Apr 16 18:46:24 CEST 2018
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25689
Change subject: mainboard/google/kahlee: Update EC pins from GPIOs to GPEs
......................................................................
mainboard/google/kahlee: Update EC pins from GPIOs to GPEs
The EC pin definitions are GPEs, not the GPIO numbers.
BUG=b:74022675
TEST=Power status updates immediately when power is inserted.
Change-Id: Icc8330a606f7a85e72b65094462a684927986829
Signed-off-by: Martin Roth <martinroth at chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/25689/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
index 1e349b7..858e33e 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h
@@ -39,8 +39,8 @@
#endif /* _ACPI__ */
-#define EC_SCI_GPI 22
-
-#define EC_SMI_GPI 6
+/* These define the GPE, not the GPIO. */
+#define EC_SCI_GPI 3 /* AGPIO 22 -> GPE 3 */
+#define EC_SMI_GPI 10 /* AGPIO 6 -> GPE 10 */
#endif /* __BASEBOARD_GPIO_H__ */
--
To view, visit https://review.coreboot.org/25689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc8330a606f7a85e72b65094462a684927986829
Gerrit-Change-Number: 25689
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180416/0b14647d/attachment-0001.html>
More information about the coreboot-gerrit
mailing list