<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25689">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Update EC pins from GPIOs to GPEs<br><br>The EC pin definitions are GPEs, not the GPIO numbers.<br><br>BUG=b:74022675<br>TEST=Power status updates immediately when power is inserted.<br><br>Change-Id: Icc8330a606f7a85e72b65094462a684927986829<br>Signed-off-by: Martin Roth <martinroth@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/25689/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>index 1e349b7..858e33e 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/gpio.h</span><br><span>@@ -39,8 +39,8 @@</span><br><span> </span><br><span> #endif /* _ACPI__ */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_SCI_GPI           22</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_SMI_GPI            6</span><br><span style="color: hsl(120, 100%, 40%);">+/* These define the GPE, not the GPIO. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_SCI_GPI                3       /* AGPIO 22 -> GPE  3 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_SMI_GPI         10      /* AGPIO 6  -> GPE 10 */</span><br><span> </span><br><span> #endif /* __BASEBOARD_GPIO_H__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25689">change 25689</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25689"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icc8330a606f7a85e72b65094462a684927986829 </div>
<div style="display:none"> Gerrit-Change-Number: 25689 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>