[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr3: improve XMP support

[Dan Elkouby (Code Review)]

Dan Elkouby has posted comments on this change. ( https://review.coreboot.org/25663 )

Change subject: device/dram/ddr3: improve XMP support
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c
File src/device/dram/ddr3.c:

https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@298
PS1, Line 298: 	/* Minimum CAS Write Latency Time (tCWLmin)
> over line
Done


https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@491
PS1, Line 491: 	/* CAS Latencies Supported */
> According to spec 1.1 it's  […]
Done


https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c
File src/device/dram/ddr3.c:

https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c@584
PS2, Line 584: 		print_ns("  tCMDmin           : ", dimm->tCMD);
> It's not in units of ns, but tCK/ns
Should I add a function along the lines of print_tck for this?



-- 
To view, visit https://review.coreboot.org/25663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4f545ed1df92c146be02f56fea0ca9037478649
Gerrit-Change-Number: 25663
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Sat, 14 Apr 2018 10:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180414/06dfe1c8/attachment.html>